You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a typo in the code for creating a plan_r2r! with numthreads != nothing.
The function returns an out of place plan_r2r in this case (the plan_r2r is missing the ! )
function plan_r2r!(X::StridedArray{T,N}, kinds, region;
flags::Integer=ESTIMATE,
timelimit::Real=NO_TIMELIMIT,
num_threads::Union{Nothing, Integer} = nothing) where {T<:fftwNumber,N}
if num_threads !== nothing
plan = set_num_threads(num_threads) do
plan_r2r(X, kinds, region; flags = flags, timelimit = timelimit)
end
return plan
end
r2rFFTWPlan{T,Any,true,N}(X, X, region, kinds, flags, timelimit)
end
If the plan is now out of place this silently breaks code relying on P*x acting in place on x since the out of place plan now does not modify x.
perhaps this is additional motivation to require lmul!(P,x) syntax for applying in place plans
The text was updated successfully, but these errors were encountered:
There is a typo in the code for creating a plan_r2r! with numthreads != nothing.
The function returns an out of place plan_r2r in this case (the plan_r2r is missing the ! )
If the plan is now out of place this silently breaks code relying on P*x acting in place on x since the out of place plan now does not modify x.
perhaps this is additional motivation to require lmul!(P,x) syntax for applying in place plans
The text was updated successfully, but these errors were encountered: