-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpecialFunctions.logabsgamma return type changed #145
Comments
We might as well change the return type to (Technically, nothing requires us to use the same integer type as |
You are correct; our input and return floating point types are different, so there is no reason our return integer type has to be the same. The PR changes the return integer type but keeps the SpecialFunction version limits the same. |
In SpecialFunctions v0.8 - v1.5 the return type of
logabsgamma
was(Floatxx, Int32)
. Starting with v1.6 it is(Floatxx, Int)
. Should we change the return type here and set the lower version limit on SpecialFunctions to v1.6?The text was updated successfully, but these errors were encountered: