Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpecialFunctions.logabsgamma return type changed #145

Closed
jmkuhn opened this issue Jul 29, 2021 · 2 comments · Fixed by #146
Closed

SpecialFunctions.logabsgamma return type changed #145

jmkuhn opened this issue Jul 29, 2021 · 2 comments · Fixed by #146

Comments

@jmkuhn
Copy link
Contributor

jmkuhn commented Jul 29, 2021

In SpecialFunctions v0.8 - v1.5 the return type of logabsgamma was (Floatxx, Int32). Starting with v1.6 it is (Floatxx, Int). Should we change the return type here and set the lower version limit on SpecialFunctions to v1.6?

@stevengj
Copy link
Member

We might as well change the return type to Int, but I don't see why we would need to change the version limit?

(Technically, nothing requires us to use the same integer type as logabsgamma(::Float64) AFAICT.)

@jmkuhn
Copy link
Contributor Author

jmkuhn commented Jul 29, 2021

You are correct; our input and return floating point types are different, so there is no reason our return integer type has to be the same. The PR changes the return integer type but keeps the SpecialFunction version limits the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants