Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVD of matrices with zero sizes #125

Merged
merged 1 commit into from
May 17, 2023
Merged

Fix SVD of matrices with zero sizes #125

merged 1 commit into from
May 17, 2023

Conversation

andreasnoack
Copy link
Member

Fixes #70

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7d68683) 96.08% compared to head (9754b00) 96.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          11       11           
  Lines        1634     1636    +2     
=======================================
+ Hits         1570     1572    +2     
  Misses         64       64           
Impacted Files Coverage Δ
src/svd.jl 97.36% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andreasnoack andreasnoack merged commit 27a78e0 into master May 17, 2023
@andreasnoack andreasnoack deleted the an/zerobidiag branch May 17, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svdvals! failing for empty matrices
1 participant