Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schur convergence with 0 eigenvalues #58

Closed
mfalt opened this issue Nov 4, 2019 · 0 comments · Fixed by #59
Closed

schur convergence with 0 eigenvalues #58

mfalt opened this issue Nov 4, 2019 · 0 comments · Fixed by #59

Comments

@mfalt
Copy link
Contributor

mfalt commented Nov 4, 2019

It seems that the _schur! algorithm gets stuck when a row and column is zero

A = [0.0 1.0 0.0;
       -1.0 0.0 0.0;
       0.0 0.0 0.0]
B = [0.0 0.0 0.0;
       0.0 0.0 1.0;
       0.0 -1.0 0.0]

eigvals(BigFloat.(A)) # Max iters reached
eigvals(BigFloat.(B)) # Max iters reached

I fixed this in an incoming PR.
This exposed another bug in _eigvals!(S::Schur{T} where the first "2x2" block in

[0.0 0.0 0.0; 0.0 0.0 1.0; 0.0 -1.0 0]

resulted in 2 zero eigenvalues, which in the end returned all zero eigenvalues.
I fixed this too, however I am not familiar with the algorithm so I might have done something stupid, but it is similar to this fix: #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant