From 416ee4648e783b3b7c650ef1ccbbcf7f712132e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tam=C3=A1s=20K=2E=20Papp?= Date: Mon, 21 Feb 2022 11:04:53 +0100 Subject: [PATCH] Add tests for issue #28869. for the issue (and a trivial typo fix). --- stdlib/LinearAlgebra/test/triangular.jl | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/stdlib/LinearAlgebra/test/triangular.jl b/stdlib/LinearAlgebra/test/triangular.jl index dfb4d7c8a0b95..d3c2817f89463 100644 --- a/stdlib/LinearAlgebra/test/triangular.jl +++ b/stdlib/LinearAlgebra/test/triangular.jl @@ -332,7 +332,7 @@ for elty1 in (Float32, Float64, BigFloat, ComplexF32, ComplexF64, Complex{BigFlo @test A1 + A2 == Matrix(A1) + Matrix(A2) @test A1 - A2 == Matrix(A1) - Matrix(A2) - # Triangular-Triangualar multiplication and division + # Triangular-Triangular multiplication and division @test A1*A2 ≈ Matrix(A1)*Matrix(A2) @test transpose(A1)*A2 ≈ transpose(Matrix(A1))*Matrix(A2) @test transpose(A1)*adjoint(A2) ≈ transpose(Matrix(A1))*adjoint(Matrix(A2)) @@ -825,4 +825,15 @@ end test_one_oneunit_triangular(c) end +@testset "LowerTriangular(Diagonal(...)) and friends (issue #28869)" begin + for elty in (Float32, Float64, BigFloat, ComplexF32, ComplexF64, Complex{BigFloat}, Int) + V = elty ≡ Int ? rand(1:10, 5) : elty.(randn(5)) + D = Diagonal(V) + for dty in (UpperTriangular, LowerTriangular) + A = dty(D) + @test A * A' == D * D' + end + end +end + end # module TestTriangular