-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Something fishy with math. consts? #9975
Comments
|
I think this is #9198 related? |
@simonbyrne can you do a quick check to see if these errors in these package tests are because they were relying on some behaviour they shouldnt? |
Yes: now all numbers should only compare equal if they are actually numerically equal, so |
Excellent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See e.g.
ERROR: LoadError: test failed: (a = 6.2831853071795... == 6.283185307179586)
ERROR: LoadError: LoadError: test failed: (0.5671432904097838 == a = 0.5671432904097...)
ERROR: LoadError: test failed: (3.141592653589793 == a = 3.1415926535897...)
The text was updated successfully, but these errors were encountered: