Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something fishy with math. consts? #9975

Closed
IainNZ opened this issue Jan 30, 2015 · 5 comments
Closed

Something fishy with math. consts? #9975

IainNZ opened this issue Jan 30, 2015 · 5 comments

Comments

@IainNZ
Copy link
Member

IainNZ commented Jan 30, 2015

See e.g.

@IainNZ
Copy link
Member Author

IainNZ commented Jan 30, 2015

  | | |_| | | | (_| |  |  Version 0.4.0-dev+2997 (2015-01-30 05:35 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit e41a507 (0 days old master)
|__/                   |  x86_64-unknown-linux-gnu

@IainNZ
Copy link
Member Author

IainNZ commented Jan 30, 2015

I think this is #9198 related?

@IainNZ
Copy link
Member Author

IainNZ commented Jan 30, 2015

@simonbyrne can you do a quick check to see if these errors in these package tests are because they were relying on some behaviour they shouldnt?

@simonbyrne
Copy link
Contributor

Yes: now all numbers should only compare equal if they are actually numerically equal, so pi != float(pi). As MathConsts usually represent irrational numbers, they will never be equal to any floating point values.

@IainNZ
Copy link
Member Author

IainNZ commented Jan 30, 2015

Excellent

@IainNZ IainNZ closed this as completed Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants