Add function for machine precision number to avoid expensive calculations in the Givens rotation algorithms #8660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
force-pushed
the
anj/givens
branch
from
3d11c1c
to
7d8dadb
Compare
| A_mul_B!(G1::Givens, G2::Givens) = error("Operation not supported. Consider *") | ||
| function A_mul_B!(G::Givens, A::AbstractMatrix) | ||
| m, n = size(A) | ||
| for i = 1:n | ||
| G.i2 <= m || throw(DimensionMismatch("column indices for ratation are outside the matrix")) |
There was a problem hiding this comment.
rotation
(and same below, L214)
andreasnoack
force-pushed
the
anj/givens
branch
from
7d8dadb
to
3d19864
Compare
andreasnoack
force-pushed
the
anj/givens
branch
from
3d19864
to
dadd6ca
Compare
andreasnoack
added a commit
that referenced
this pull request
Oct 14, 2014
Add function for machine precision number to avoid expensive calculations in the Givens rotation algorithms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That appears to give more than three times speedup.
This pr also removes the subtype relation to AbstractMatrix and therefore also the now unnecessary ambiguity avoiding method definitions. The size parameter is remove as it is an unnecessary restriction. Finally, the pr adds
@simdand@inboundsin the methods for applying Givens rotations.[pao: quoting]