Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using julia_cmd during precompilation propagates JULIA_CPU_TARGET #49912

Open
vchuravy opened this issue May 21, 2023 · 0 comments
Open

Using julia_cmd during precompilation propagates JULIA_CPU_TARGET #49912

vchuravy opened this issue May 21, 2023 · 0 comments
Labels
kind:bug Indicates an unexpected problem or unintended behavior kind:regression Regression in behavior compared to a previous version

Comments

@vchuravy
Copy link
Sponsor Member

For pkgimages I added the ability to set -C from julia_cmd flag.

cpu_target = unsafe_string(opts.cpu_target)

In the same motion I added the propagation of the -C flag to julia_cmd. Our current recommendation for people who want
to use multi-versioning for pkgimages is to set JULIA_CPU_TARGET="generic;sandybridge,-xsaveopt,clone_all;haswell,-rdrnd,base(1)",

I just came across a package (AMDGPU) in the wild that uses julia_cmd during precompilation...

cmd = Base.julia_cmd() = `/home/rocm-user/julia-1.9.0/bin/julia '-Cgeneric;sandybridge,-xsaveopt,clone_all;haswell,-rdrnd,base(1)' -J/home/rocm-user/julia-1.9.0/lib/julia/sys.so -g1 --color=yes --startup-file=no`
More than one command line CPU targets specified without a `--output-` flag specified

Not sure what the correct solution here is...

@vchuravy vchuravy added kind:bug Indicates an unexpected problem or unintended behavior kind:regression Regression in behavior compared to a previous version labels May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Indicates an unexpected problem or unintended behavior kind:regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

1 participant