Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running doc only PRs through only the doctest CI #45744

Open
ViralBShah opened this issue Jun 19, 2022 · 3 comments
Open

Running doc only PRs through only the doctest CI #45744

ViralBShah opened this issue Jun 19, 2022 · 3 comments
Labels
docsystem The documentation building system domain:ci Continuous integration kind:feature Indicates new feature / enhancement requests

Comments

@ViralBShah
Copy link
Member

I wonder if we can adopt a PR submission workflow, where PR submitters can pick the nature of their PR. For example, if it is doc only, they say so during PR submission, which can assign a label and the CI system can then just use that label to run only doctests related CI.

cc @DilumAluthge @staticfloat

@ViralBShah ViralBShah added domain:ci Continuous integration docsystem The documentation building system labels Jun 19, 2022
@DilumAluthge
Copy link
Member

Instead of having the user pick a label, I think it will be better if:

  1. Our CI system computes the list of files modified in the PR.
  2. If only doc-related files are modified, the CI system automatically skips the non-doctest tests.

@ViralBShah
Copy link
Member Author

It is not easy to do that, because most of the doc changes are actually in .jl files. Checking if only the manual changed would miss out the API docs changes that go into the .jl files.

@vtjnash vtjnash added the kind:feature Indicates new feature / enhancement requests label Sep 28, 2022
@DilumAluthge
Copy link
Member

Cross-ref JuliaCI/julia-buildkite#243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docsystem The documentation building system domain:ci Continuous integration kind:feature Indicates new feature / enhancement requests
Projects
None yet
Development

No branches or pull requests

3 participants