Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define dot between AbstractMatrix and UniformScaling #40250

Merged
merged 5 commits into from
Apr 13, 2021
Merged

define dot between AbstractMatrix and UniformScaling #40250

merged 5 commits into from
Apr 13, 2021

Conversation

lkapelevich
Copy link
Contributor

closes #40248

@dkarrasch dkarrasch added the domain:linear algebra Linear algebra label Mar 29, 2021
sethaxen
sethaxen suggested changes Mar 30, 2021
View reviewed changes
stdlib/LinearAlgebra/src/uniformscaling.jl Outdated Show resolved Hide resolved
stdlib/LinearAlgebra/test/uniformscaling.jl Outdated Show resolved Hide resolved
@chriscoey
Copy link

bump!

@stevengj
Copy link
Member

stevengj commented Apr 7, 2021

LGTM; it's consistent with treating I as a square matrix of appropriate size in + and *

@stevengj stevengj added the needs news A NEWS entry is required for this change label Apr 7, 2021
@stevengj
Copy link
Member

stevengj commented Apr 7, 2021

Needs a NEWS entry, though.

@stevengj stevengj removed the needs news A NEWS entry is required for this change label Apr 7, 2021
@kshyatt
Copy link
Contributor

kshyatt commented Apr 13, 2021

Anything holding this up?

@lkapelevich
Copy link
Contributor Author

i don't see anything on my end

@stevengj stevengj merged commit d88ed01 into JuliaLang:master Apr 13, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@lkapelevich @ElOceanografo
define dot between AbstractMatrix and UniformScaling (JuliaLang#40250)
09ff96f 
* define dot between AbstractMatrix and UniformScaling

* fix equality check

* fix for complex

* add news entry
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@lkapelevich @antoine-levitt
define dot between AbstractMatrix and UniformScaling (JuliaLang#40250)
e60ba1e 
* define dot between AbstractMatrix and UniformScaling

* fix equality check

* fix for complex

* add news entry
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@lkapelevich @johanmon
define dot between AbstractMatrix and UniformScaling (JuliaLang#40250)
b56ef95 
* define dot between AbstractMatrix and UniformScaling

* fix equality check

* fix for complex

* add news entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj approved these changes

@sethaxen sethaxen sethaxen approved these changes

Assignees
No one assigned
Labels
domain:linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define dot between UniformScaling and Matrix
6 participants
@lkapelevich @chriscoey @stevengj @kshyatt @sethaxen @dkarrasch