Preserve Hessenberg shape when possible #40039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Apr 7, 2021
|
(Needs a NEWS.md entry.) |
|
I added a NEWS entry. |
stevengj
reviewed
Apr 7, 2021
stevengj
approved these changes
Apr 10, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* Preserve Hessenberg shape when possible * Remove obsolete comments * Add NEWS * Support for unitful Hessenberg matrices * Mark some tests for unitful matrices as broken
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* Preserve Hessenberg shape when possible * Remove obsolete comments * Add NEWS * Support for unitful Hessenberg matrices * Mark some tests for unitful matrices as broken
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
* Preserve Hessenberg shape when possible * Remove obsolete comments * Add NEWS * Support for unitful Hessenberg matrices * Mark some tests for unitful matrices as broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preserves the
UpperHessenbergshape in cases where the result is of that shape, for example when multipyling by aDiagonalor anUpperTriangular.Fixes #39388.