-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible breakage in 1.6.0-rc2 and nightly in evaluating CartesianIndices for OffsetArrays with BigInt parent ranges #40035
Comments
Looks like this was introduced by #37829 |
Related to #39589? |
It's not unrelated as the same constructor is called eventually, but this seems to be a different issue (the other one is primarily due to how the integer is converted to a range). This issue can be fixed by adding a specialized |
This works on 1.6.5, on 1.7.2 and on master - Is there any reason not to close this (and #40038)? |
If it works on those releases, it seems indeed a good idea to close. |
Whoops, I tested that PR and it is still needed. Left a comment there about how we could finish that. |
Unfortunately there's a bug on master in
OffsetArrays
currently, so this PR is necessary to see the issue:on 1.5.4:
on 1.6.0-rc2 and nightly:
This is due to a missing method for the
IdOffsetRange
axis type defined inOffsetArrays
, but this conversion is not used in 1.5.4. The conversion carried out byCartesianIndices
appears to have changed from anAbstractUnitRange{Int}
in 1.5.4 to anOrdinalRange{Int,Int}
in 1.6.The text was updated successfully, but these errors were encountered: