Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export mmap from Mmap #39816

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Export mmap from Mmap #39816

merged 2 commits into from
Mar 10, 2021

Conversation

ararslan
Copy link
Member

Currently, one needs Mmap.mmap, which is unnecessarily redundant.

@ararslan
Export mmap from Mmap
fe4bb8d 
Currently, one needs `Mmap.mmap`, which is unnecessarily redundant.
@ararslan ararslan added the stdlib Julia's standard library label Feb 24, 2021
Sacha0
Sacha0 approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nominally LGTM, though I imagine there might've been a reason for not exporting it? :)

@quinnj
Copy link
Member

quinnj commented Feb 24, 2021

Not really. I just don't mind the extra referencing myself and there's never a risk of clashing. But I think this is fine.

@ararslan
Copy link
Member Author

Good to go then?

@ararslan
Copy link
Member Author

This has been open for two weeks with approval from Sacha, an okay from Jacob, and no word from Jeff, so I'm just going to go ahead and merge under the assumption that this isn't heinously objectionable. Thanks all!

@ararslan ararslan merged commit f8125c0 into master Mar 10, 2021
@ararslan ararslan deleted the aa/export-mmap branch March 10, 2021 19:39
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@ararslan @ElOceanografo
Export mmap from Mmap (JuliaLang#39816)
47d2fea 
Currently, one needs `Mmap.mmap`, which is unnecessarily redundant.
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@ararslan @antoine-levitt
Export mmap from Mmap (JuliaLang#39816)
34056d9 
Currently, one needs `Mmap.mmap`, which is unnecessarily redundant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

Assignees
No one assigned
Labels
stdlib Julia's standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ararslan @quinnj @Sacha0