Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursively check wrapper arrays for issparse #37644

Closed
wants to merge 2 commits into from

Conversation

oxinabox
Copy link
Contributor

Do we want this?
I don't know.
What does it mean to be issparse?
I haven't seen a defination of an interface that must be furfilled.

Possibly all people want this for is to know if they have some algorthm that really won't run great on a sparse array, then they could issue a warning or run collect to make it dense.

issparse compiles away.

julia> @code_llvm debuginfo=:none issparse(Transpose(Base.ReshapedArray(Symmetric(m), (20, 5), ())))

define i8 @julia_issparse_2137([1 x { { { i64, i64, {}*, {}*, {}* }, i32 }, [2 x i64] }]* nocapture nonnull readonly align 8 dereferenceable(64)) {
top:
  ret i8 1
}

julia> @code_llvm debuginfo=:none issparse(Transpose(Base.ReshapedArray(Symmetric(Array(m)), (20, 5), ())))

define i8 @julia_issparse_2139([1 x { { {}*, i32 }, [2 x i64] }]* nocapture nonnull readonly align 8 dereferenceable(32)) {
top:
  ret i8 0
}

@fredrikekre
Copy link
Member

#34308 ?

@oxinabox
Copy link
Contributor Author

oxinabox commented Sep 18, 2020

Huh, apparently i already made this PR.
Go past me.

I will forcepush this branch over to that one

@oxinabox oxinabox closed this Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants