fix table column alignment in html output #33849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just came across this the other day but didn't have the time to dig in to what was needed to fix that! |
|
This broke some of my tests, which is fine as I was expecting the old output without alignment, however it took me some time to work out where this PR was, should this not be in NEWS? also will it be part of 1.3 or is it only >=1.4? |
|
Added a needs news label. @pfitzseb, would you mind adding an appropriate NEWS entry? |
pfitzseb
added a commit
to pfitzseb/julia
that referenced
this pull request
Nov 27, 2019
fredrikekre
pushed a commit
that referenced
this pull request
Dec 5, 2019
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The html output of markdown tables doesn't correctly set the horizontal alignment. This PR fixes that.