-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instance of mutable struct does not compare equal to deepcopied instance #33359
Labels
kind:regression
Regression in behavior compared to a previous version
Comments
KristofferC
added
the
kind:regression
Regression in behavior compared to a previous version
label
Sep 22, 2019
This was referenced Sep 22, 2019
KristofferC
removed
the
kind:regression
Regression in behavior compared to a previous version
label
Sep 22, 2019
KristofferC
changed the title
Singleton values (of mutable struct) are sometimes not equal
Instance of mutable struct does not compare equal to same instance
Sep 22, 2019
KristofferC
added
the
kind:regression
Regression in behavior compared to a previous version
label
Sep 22, 2019
KristofferC
changed the title
Instance of mutable struct does not compare equal to same instance
Instance of mutable struct does not compare equal to deepcopied instance
Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Edit: Reduced to this:
1.3:
1.2:
Looking at the test regression for 1.3-RC3 vs 1.2 in Alpine.jl I find that on 1.3:
while on 1.2
UnsetSolver
is a singleton mutable struct defined here:https://github.com/lanl-ansi/Alpine.jl/blob/b0d97aadd402a26fdb8c833871d0350fdc2c6378/src/solver.jl#L318-L321
and the same constant is assigned to the field
minlp_solver
field:https://github.com/lanl-ansi/Alpine.jl/blob/b0d97aadd402a26fdb8c833871d0350fdc2c6378/src/solver.jl#L400-L402
Making it non-mutable works around the problem.
The text was updated successfully, but these errors were encountered: