-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance regression in skipchars #33335
Labels
Comments
KristofferC
added
performance
Must go faster
kind:regression
Regression in behavior compared to a previous version
labels
Sep 20, 2019
cc @vtjnash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
skipchars
took a 5x preformance hit (for the benchmark we have in BaseBenchmarks) presumably after the introduction of locks on thewrite
calls.Perhaps we can lock outside of the loop and write without a lock and finally unlock it when we are done?
The text was updated successfully, but these errors were encountered: