Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression in skipchars #33335

Closed
KristofferC opened this issue Sep 20, 2019 · 2 comments
Closed

Performance regression in skipchars #33335

KristofferC opened this issue Sep 20, 2019 · 2 comments
Labels
kind:regression Regression in behavior compared to a previous version performance Must go faster

Comments

@KristofferC
Copy link
Sponsor Member

skipchars took a 5x preformance hit (for the benchmark we have in BaseBenchmarks) presumably after the introduction of locks on the write calls.

Perhaps we can lock outside of the loop and write without a lock and finally unlock it when we are done?

@KristofferC KristofferC added performance Must go faster kind:regression Regression in behavior compared to a previous version labels Sep 20, 2019
@StefanKarpinski
Copy link
Sponsor Member

cc @vtjnash

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jan 28, 2021

Duplicate of #34195 / addressed in #35426. We might be able to do some more automatic compiler optimization of this in the future, instead of the optimization provided there, though it breaks some forward-progress guarantees required by that code pattern in general, so remains to be investigated.

@vtjnash vtjnash closed this as completed Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:regression Regression in behavior compared to a previous version performance Must go faster
Projects
None yet
Development

No branches or pull requests

3 participants