Broadcast AbstractRNG like a scalar #33213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nickrobinson251
commented
Sep 10, 2019
•
- closes AbstractRNG should be a broadcast scalar #31071
- i think this is in-keeping with the de-facto heuristic on how things broadcast, which i think of as "something that's obviously not a collection broadcasts like a scalar, as long as there's a reasonable use-case for that behaviour"
- ideally we'd test this on a new/test-only AbstractRNG, but i wasn't sure exactly what would need to be implemented and if it'd be worth it... so this is just tested on the two subtypes definited in the module :)
7f9501c
to
efd8a0f
Compare
oxinabox
reviewed
Sep 16, 2019
stevengj
requested changes
Sep 17, 2019
b63df1f
to
efd8a0f
Compare
stevengj
approved these changes
Sep 17, 2019
stevengj
approved these changes
Sep 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.