Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing exclamation marks to names of mutating linear algebra functions #3291

Closed
johnmyleswhite opened this issue Jun 4, 2013 · 7 comments
Labels
kind:breaking This change will break code needs decision A decision on this change is needed
Milestone

Comments

@johnmyleswhite
Copy link
Member

The "backend" layer of the linear algebra system currently violates our design decision to require that all mutating functions include a ! in their names. For example, A_mul_B(C, A, B) should really be named A_mul_B!(C, A, B) because it mutates C.

@ViralBShah
Copy link
Member

Reasonable. +1.

@lindahua
Copy link
Contributor

Sounds good to me.

This may probably break quite a few of my packages. However, the fix would be easy.

@ViralBShah
Copy link
Member

We should be able to avoid breakage with deprecation.

@ViralBShah
Copy link
Member

We should definitely try to do this for 0.2. Will probably require parser changes, but is relatively easy. Cc: @JeffBezanson

@Keno
Copy link
Member

Keno commented Aug 28, 2013

Bump.

@JeffBezanson
Copy link
Sponsor Member

Parser changes not needed, since the parser doesn't generate calls to mutating versions of these functions.

@ViralBShah
Copy link
Member

How about doing this with the 3-arg forms of solve as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:breaking This change will break code needs decision A decision on this change is needed
Projects
None yet
Development

No branches or pull requests

5 participants