-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing exclamation marks to names of mutating linear algebra functions #3291
Comments
Reasonable. +1. |
Sounds good to me. This may probably break quite a few of my packages. However, the fix would be easy. |
We should be able to avoid breakage with deprecation. |
We should definitely try to do this for 0.2. Will probably require parser changes, but is relatively easy. Cc: @JeffBezanson |
Bump. |
Parser changes not needed, since the parser doesn't generate calls to mutating versions of these functions. |
How about doing this with the 3-arg forms of |
The "backend" layer of the linear algebra system currently violates our design decision to require that all mutating functions include a
!
in their names. For example,A_mul_B(C, A, B)
should really be namedA_mul_B!(C, A, B)
because it mutatesC
.The text was updated successfully, but these errors were encountered: