Add indexing support to SkipMissing #31008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define
IndexStyle
,eachindex
,keys
andgetindex
to match indices of wrapped array, skipping missing entries. This notably allows finding the index of elements in the wrapped array usingfindall
,findnext
,argmin
/max
andfindmin
/max
.Fixes #29305. Part of #30606.
FWIW, iterating over
SkipMissing
usingeachindex
andgetindex
rather thaniterate
is slower, but not that much (and I see no reason why the compiler couldn't improve since the involved code is quite simple)EDIT: with@inbounds
annotations both solutions have the same performance (but the performance difference persists without it).