Deprecate squeeze(A, dims) to use keyword arguments #26660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbauman
added
domain:arrays
ararslan
reviewed
Mar 29, 2018
base/abstractarraymath.jl
Outdated
| 2×2×1 Array{Int64,3}: | ||
| [:, :, 1] = | ||
| 1 3 | ||
| 2 4 | ||
| ``` | ||
| """ | ||
| function squeeze(A::AbstractArray, dims::Dims) | ||
| squeeze(A; dims=throw(ArgumentError("the dimensions to squeeze must be specified with a `dims` keyword argument"))) = _squeeze(A, dims) |
There was a problem hiding this comment.
You should be able to get by with a required keyword argument here:
squeeze(A; dims) = _squeeze(A, dims)That will throw an UndefKeywordError when dims is not provided.
There was a problem hiding this comment.
Oh, right, I forgot we do this automatically now. Thanks!
I forgot this existed
mbauman
force-pushed
the
mb/squeezekwdim
branch
from
d5f62c9
to
30399e5
Compare
ararslan
approved these changes
Mar 29, 2018
|
64-bit Windows failure is a timeout. |
|
Wow, apparently kwarg codegen has significantly improved since 0.6. Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to issue #25501 and seems to make sense in that same vein. This also adds NEWS for squeeze and all the other related functions (#25501 was missing NEWS).