Deprecate diff(::AbstractMatrix), require a dim argument #25457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akin to `cumsum`, `diff` now requires a `dim` argument in cases where the array has more than one dimension. Final piece of #20041 for the 1.0 milestone.
mbauman
added
domain:arrays
Sacha0
approved these changes
Jan 8, 2018
fredrikekre
approved these changes
Jan 8, 2018
NEWS.md
Outdated
| argument instead of defaulting to using the first dimension ([#24684]). | ||
| * `cumsum`, `cumprod`, `accumulate`, their mutating versions, and `diff` all now require a `dim` | ||
| argument instead of defaulting to using the first dimension unless there is only | ||
| one dimension ([#24684]). |
There was a problem hiding this comment.
Perhaps add a reference to this PR too :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Akin to
cumsum,diffnow requires adimargument in cases where the array has more than one dimension. Final piece of #20041 for the 1.0 milestone.