RFC: extend unsafe_assign to work for any isbits type, add pointer_from_objref #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added a commit
that referenced
this pull request
Mar 8, 2013
RFC: extend unsafe_assign to work for any isbits type, add pointer_from_objref
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attached patch modifies the
pointersetandpointerrefintrinsics to checkisbitsrather thanis_bitstype, so that they use the same code for any pointer-free immutable type.It also adds a
pointer_from_objreffunction which is the inverse ofunsafe_pointer_to_objref.Both of these functions are motivated by the desire to be able to store
jl_value_t*pointers in a Cstructgiven a pointer to the latter, as discussed on julia-dev.