deprecate fill!(A::[Diagonal|AbstractTriangular], x) = fillslots!(A, x) methods #24413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request deprecates two methods,
fill!(A::S, x) = fillslots!(A, x)
forS
in(Diagonal, AbstractTriangular)
. As the comment attached to the associated definitions states, these methods are an artifact of history.Should we consider deprecating
fill!(A, x)
for structuredA
as well? Unlessx
is zero orA
is small enough that all entries are mutable (i.e.A
is one-by-one or two-by-two depending on the special matrix type),fill!(A, x)
errors.Best!