make I consistently provide identity behavior in type #24396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently
I
isUniformScaling{Int64}(1)
, which consistently provides identity behavior in value but inconsistently in type:This pull request makes
I
yieldUniformScaling{Bool}(true)
instead, which consistently provides identity behavior not merely in value but also in type. Ref. #23156, and particularly the latter paragraphs in #23156 (comment), which this pull request partially addresses. Best!