go gentle into that good night, full #24250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sacha0
added
domain:arrays
|
That's one hell of a deprecation. |
|
Updated with PR# in NEWS.md. Absent objections or requests for time, I plan to merge this deprecation in the next day or two. Best! |
fredrikekre
approved these changes
Oct 22, 2017
|
It looks like there is still an |
|
|
Thanks all! :) |
This was referenced Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dylan Thomas would much admire how you have raged, raged against the dying of the light,
full. But even he would insist that close of day has come. So go gentle into that good night,full. And when you do, please take #12153, #12251, and #18850 with you.(... in case that reference is too obscure, this pull request finally deprecates
full, and closes #12153, #12251, and #18850. Best!)