Doctest ALL the things

[KristofferC]

This is a list of all files that need doctests in the manual. If you have a PR in progress to doctest a file please claim it here. This is in order for people not to do double work. If there is a file that you know of that is fully doctests, please mention it as well.

• Introduction] - @fredrikekre Doctests for the manual, part 1 #20183
• Getting Started - @fredrikekre Doctests for the manual, part 1 #20183
• Variables - @fredrikekre Doctests for the manual, part 1 #20183
• Integers and Floating-Point Numbers - @fredrikekre Doctests for the manual, part 1 #20183
• Mathematical Operations and Elementary Functions - @fredrikekre Doctests for the manual, part 1 #20183
• Complex and Rational Numbers - @fredrikekre Doctests for the manual, part 1 #20183
• Strings - @fredrikekre Doctests for the manual, part 1 #20183
• Functions - @fredrikekre doctests for manual/functions.md (part 2) #20201
• Control Flow - @fredrikekre doctests for the manual, part 3 #20202
• Scope of Variables - @fredrikekre doctests for the manual, part 3 #20202
• Types - @fredrikekre Manual doctests (part 4) #20224
• Methods - @fredrikekre Manual doctests (part 4) #20224
• Constructors - @kshyatt Doctests for manual/constructors #20285
• Conversion and Promotion - @kshyatt Convert conversion-and-promotion.md to doctests #20297
• Interfaces - @fredrikekre doctests for interface.md #20287
• Modules - Nothing runnable
• Documentation - no doctests but some updates: @KristofferC small updates to documentation [ci skip] #20442
• Metaprogramming - @KristofferC doctests for metaprogramming #20302
• Multi-dimensional Arrays - misc doc tweaks for manual/arrays.md #20125
• Linear algebra -
• Networking and Streams - @KristofferC add a few doctests and updates to networking and streams #20304
• Parallel Computing -
• Date and DateTime - @KristofferC Add doctest to dates #20275
• Running External Programs - @fredrikekre doctests for running-external-programs.md, [ci skip] #20315
• Calling C and Fortran Code - @KristofferC doctests for calling c and fortran #20440
• Handling Operating System Variation - No runnable examples
• Interacting With Julia - @fredrikekre
• Embedding Julia - Not doctestable
• Packages - Not so many doctests here but examples should be run through and output updated
• Package Development -
• Profiling -
• Stack Traces -
• Performance Tips - @KristofferC doctest and updates to performance tips #20312
• Workflow Tips -
• Style Guide - @fredrikekre
• Frequently Asked Questions - @KristofferC doctest faq.md #20291
• Noteworthy Differences from other Languages - Doees not contain any examples
• Unicode Input - Does not contain any examples

cc @fredrikekre.

[fredrikekre]

#20183 covers:

• Introduction
• Getting Started
• Variables
• Integers and Floating-Point Numbers
• Mathematical Operations and Elementary Functions
• Complex and Rational Number
• Strings

#20201 covers:

• Functions

#20202 covers:

• Control Flow
• Scope of Variables

#20224 covers:

• Types
• Methods

[kshyatt]

The Linear Algebra section of the manual is already doctested, in #19733

[fredrikekre]

#20125 was Multidimensional Arrays

[kshyatt]

Note that many of these files could certainly use more doctested examples, even if the conversion of existing ones is complete!

[KristofferC]

Yeah that is always the case. This issue is mostly to make sure the current stuff is correct.

[fredrikekre]

Interfaces: #20287

[fredrikekre]

#20288
Let's just start over :p

[KristofferC]

Rip.

[pkofod]

Good thing you only yolo once... Is there an easy way to see what doc tests were affected, or is it just brute force going through them all on the latest master?

[KristofferC]

just run the tests and go through them I think

[pkofod]

Okay... Don't know if any of you have started, but I'm working my way though the spaces.

[pkofod]

Documenter: populating indices.
ERROR: LoadError: `makedocs` encountered an error. Terminating build

Is this expected during make -C doc doctest ?

[KristofferC]

Hmm.. I haven't seen it before.

[tkelman]

I'm not seeing that locally? nevermind I do, but only after it has run most or all of the doctests - I'm guessing that might be expected if the doctests are failing?

We should think about adding a doctest mode to documenter that outputs valid patch files you could just pipe to git apply. You'd want to manually review the change before committing it, but would be good to automate mechanical fixes like this.

[KristofferC]

That'd be pretty cool!

[pkofod]

I'm not seeing that locally?

I'll try to checkout master to see if it was any of my changes that caused it.

We should think about adding a doctest mode to documenter that outputs valid patch files you could just pipe to git apply. You'd want to manually review the change before committing it, but would be good to automate mechanical fixes like this.

good idea

[pkofod]

Hm, this is the full error

Documenter: populating indices.
ERROR: LoadError: `makedocs` encountered an error. Terminating build
Stacktrace:
 [1] runner(::Type{Documenter.Builder.RenderDocument}, ::Documenter.Documents.Document) at /home/pkm/julia/julia/doc/deps/v0.6/Documenter/src/Builder.jl:202
 [2] dispatch(::Type{Documenter.Builder.DocumentPipeline}, ::Documenter.Documents.Document) at /home/pkm/julia/julia/doc/deps/v0.6/Documenter/src/Selectors.jl:164
 [3] cd(::Documenter.##2#3{Documenter.Documents.Document}, ::String) at ./file.jl:69
 [4] #makedocs#1(::Bool, ::Array{Any,1}, ::Function) at /home/pkm/julia/julia/doc/deps/v0.6/Documenter/src/Documenter.jl:159
 [5] (::Documenter.#kw##makedocs)(::Array{Any,1}, ::Documenter.#makedocs) at ./<missing>:0
 [6] include_from_node1(::String) at ./loading.jl:539
 [7] include(::String) at ./sysimg.jl:14
 [8] process_options(::Base.JLOptions) at ./client.jl:304
 [9] _start() at ./client.jl:370
while loading /home/pkm/julia/julia/doc/make.jl, in expression starting on line 115
Makefile:54: recipe for target 'doctest' failed
make: *** [doctest] Error 1
make: Leaving directory '/home/pkm/julia/julia/doc'

is this simply because there were doctest errors?

[StefanKarpinski]

Wouldn't it be easier to just run all the doctests through julia and replace the output in the docs? Then doing git diff would show you the changes. Needing to do git apply to apply them seems like an unnecessary complication. Then the script that does that doesn't need to know anything about git or diffs.

[KristofferC]

That would remove the error checking part from the doctests I guess but perhaps it's fine to say that tests should just be in CI

[tkelman]

I wouldn't want running the doctests to write changes to base sources by default, what if you build from a release tarball and do that.

[StefanKarpinski]

Obviously not, but it could be a different make target.

[KristofferC]

@pkofod yes, if you run in strict mode then that will happen if there are any errors in the build

[KristofferC]

For now I suggest working locally with #20288 reverted, and when someone (maybe @pkofod) makes a PR that fixes all from that we all switch over. Else everything will conflict and it will be a mess.

[pkofod]

For now I suggest working locally with #20288 reverted, and when someone (maybe @pkofod) makes a PR that fixes all from that we all switch over. Else everything will conflict and it will be a mess.

I am on it, I've just been AFK for a while. I'll make a PR when they're adjusted. (edit is fixed in #20417 by vtjnash)

[ararslan]

I just want to say thank you all so much for doing this, it's fantastic! 💯

[KristofferC]

Nice job broses and sises.

[KristofferC]

Actually, #20297 is still open. Oh well. I close this anyway :P