Implement rand(::Dict) and rand(::Set) (fix #16231) #18155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update master
Performant random implementation for Dict and Set types.
|
Note that it's better for the first line of the commit to be more informative at a glance and record what the commit fixes in the body of the commit message. I used the (handy) GitHub squash-merge feature to rewrite the commit message (while preserving your authorship), but thought I'd point it out for future reference. Thanks for the fix! |
tkelman
added
the
kind:potential benchmark
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
rfourquet
added
the
domain:randomness
rfourquet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16231
Performant random implementation for Dict, Set types.