Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intrinsic misuse causes segfault #17538

Closed
maleadt opened this issue Jul 21, 2016 · 5 comments
Closed

Intrinsic misuse causes segfault #17538

maleadt opened this issue Jul 21, 2016 · 5 comments
Labels
kind:regression Regression in behavior compared to a previous version

Comments

@maleadt
Copy link
Member

maleadt commented Jul 21, 2016

Since 7a6a9e0#diff-1c5f176b087e9647926b0146fd80117eL823 from #13485 the number of arguments to an intrinsic isn't checked anymore, commonly resulting in segfaults when passing too few of them:

julia> Base.box(1)

signal (11): Segmentation fault

While on 0.4:

julia> Base.box(1)
ERROR: error compiling anonymous: box: wrong number of arguments

I'm sure there's a plan forward here, and while intrinsic aren't meant to be used without care it doesn't seem like a good plan to just have them fault where there used to be some form of error reporting.

cc @vtjnash

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jul 21, 2016

Oscar (https://github.com/JuliaLang/julia/compare/ob/interp_call) and I (https://github.com/JuliaLang/julia/compare/jn/jlinterpreter) have fixed this, but we have just been bad about getting it onto master.

@JeffBezanson JeffBezanson added the kind:regression Regression in behavior compared to a previous version label Jul 22, 2016
@KristofferC
Copy link
Sponsor Member

Base.box is now gone.

@maleadt
Copy link
Member Author

maleadt commented Jan 23, 2017

Well, this issue wasn't about Base.box really, but it seems like intrinsic calls (both interpreted and compiled) do check their arguments again so this can be closed.

@KristofferC
Copy link
Sponsor Member

Sorry for premature closing and thanks for checking.

@maleadt
Copy link
Member Author

maleadt commented Jan 23, 2017

No problem, thanks for working your way through stale issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

4 participants