Support vector type in AArch64 C abi #16645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| // Since `dt` is pointer free and has no padding and is 8 or 16 in size. | ||
| // `ft0` must be concrete, immutable with no padding and we don't need | ||
| // to check if it's size is legal since it is automatically done by |
[ci skip]
| return _mm_add_ps(a, _mm_mul_ps(b, _mm_sub_ps(c, d))); | ||
| } | ||
|
|
||
| #endif | ||
|
|
||
| #ifdef _CPU_AARCH64_ |
There was a problem hiding this comment.
Why are these tests aarch64 specific?
There was a problem hiding this comment.
__int128, __fp16 and the vector types used below are AArch64 extensions (especially when passed as arguments or return values). I'm pretty sure at least __fp16 is not allowed as return value elsewhere (even when similar type is defined in C).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add more tests about aarch64 specific features (
__fp16,__int128, homogeneous short vector aggregate).