Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Power ABI #16455

Closed
ViralBShah opened this issue May 19, 2016 · 14 comments
Closed

Implement Power ABI #16455

ViralBShah opened this issue May 19, 2016 · 14 comments
Labels

Comments

@ViralBShah
Copy link
Member

As the power port is advancing rapidly, the biggest remaining hurdle is now the C ABI. Opening this issue to track work towards getting the ABI working on Power.

@ViralBShah ViralBShah added the system:powerpc PowerPC label May 19, 2016
@edelsohn
Copy link

This involves implementation of the PPC64 ELFv2 ABI in the Julia front-end for LLVM -- matching the definition in the LLVM backend for PPC64, and addressing lingering testsuite failures.

@vtjnash vtjnash mentioned this issue May 31, 2016
@ViralBShah
Copy link
Member Author

The Vector ABI remains now. @edelsohn Would be great if someone on your side can test this out.

@edelsohn
Copy link

We have done some more testing, but it is unclear which tests should succeed without vector ABI support, i.e., the expected status of the testsuite is confusing.

@yuyichao
Copy link
Contributor

I dont think any part of the test should depend on vector abi on power

@edelsohn
Copy link

We still see a number of errors with "make check". Are those present in your tests? Have they been traced to Julia code or LLVM code?

@yuyichao
Copy link
Contributor

(I dont have the hardware but) I think it would be better to just paste the error.

@StefanKarpinski
Copy link
Sponsor Member

Or send to @ViralBShah if preferred.

@Keno
Copy link
Member

Keno commented Jun 17, 2016

What version of LLVM did you try with? I know @vtjnash had to fix a couple LLVM bugs. I believe they all should be in the build system if you're using the default configuration, but you may not have them yet if you're using a custom LLVM.

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 17, 2016

I ran into a number of openblas bugs, so I had to run the testsuite against the system reference blas. The result was that all tests passed for me (for reference, the last time I've run the whole test-suite was merging #16677).

I started writing tests for the POWER vector ABI: 33209f3, but they aren't yet part of the regular test-suite.

@edelsohn
Copy link

Have you reported any of the OpenBLAS bugs?

@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 17, 2016

no, I hadn't worked on isolating them

@edelsohn
Copy link

Would you please reach out to Xianyi about the testsuite failures that are tied to OpenBLAS?

@Keno
Copy link
Member

Keno commented Jul 1, 2016

Vector ABI is merged, this should be complete.

@Keno Keno closed this as completed Jul 1, 2016
@ViralBShah
Copy link
Member Author

cc @xianyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants