deprecate histogram functionality #16450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the |
simonbyrne
force-pushed
the
sb/histdep
branch
4 times, most recently
from
1f7d843
to
aaae574
Compare
| @@ -334,17 +334,23 @@ for rng in ([], [MersenneTwister()], [RandomDevice()]) | |||
| end | |||
| end | |||
|
|
|||
| function hist(X,n) | |||
| v = zero(Int,n) | |||
|
@simonbyrne this wasn't added to NEWS, was it? edit: check if https://github.com/JuliaLang/julia/pull/17779/files#diff-8312ad0561ef661716b48d09478362f3R272 looks okay |
|
No, I don't think so; the change looks good. |
tkelman
reviewed
Jan 2, 2017
|
|
||
| ## midpoints of intervals | ||
| midpoints(r::Range) = r[1:length(r)-1] + 0.5*step(r) | ||
| midpoints(v::AbstractVector) = [0.5*(v[i] + v[i+1]) for i in 1:length(v)-1] |
There was a problem hiding this comment.
these were missing depwarns - they're still exported and tested...
tkelman
added a commit
that referenced
this pull request
Jan 16, 2017
and actually deprecate it - this was moved to deprecated.jl in #16450, but not actually deprecated
tkelman
added a commit
that referenced
this pull request
Jan 17, 2017
and actually deprecate it - this was moved to deprecated.jl in #16450, but not actually deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated PR from #6842