Changed issym to issymmetric.

[pkofod]

Fixes #15182 .

grepping /julia/ tells me that there is an issym variable in some .c-files left, but they should obviously not be changed (they are boolean variables asking if a variable is a symbol by the way, so that strengthens the need for being precise).

There is something I still need to do. grep -r issym still tells me (relevant) issym's still live in
contrib/BBEditTextWrangler-julia.plist
base/docs/helpdb/Base.jl
doc/stdlib/linalg.rst

I am unsure how the documentation system works in julia. Should I just change these files as well, or are some things auto-generated, and others are not - or? Thanks.

Edit: Obviously also need to deprecate issym, will do in the morning

[andreasnoack]

Regarding the documentation then check out https://github.com/JuliaLang/julia/blob/master/CONTRIBUTING.md#improving-documentation. However, it can be a little confusing so feel free to ask.

[pkofod]

Thanks for the pointer. I hope I did it correctly, let's see if it builds on the CI-services. I could generate the docs locally without errors at least.

I also @deprecated issym issymmetric.

[pkofod]

I had missed an issym in linalg/dense.jl, but only the linux builds failed on travis, the OSX builts were OK. Is that supposed to be possible? https://travis-ci.org/JuliaLang/julia/builds/111159068

[tkelman]

OSX Travis is not currently running all tests to avoid timing out.

This looks good, thanks! I like git grep for this kind of renaming check.

[pkofod]

Sounds like i could have benefitted from git grep. Cool, will use that next time.

[pkofod]

Are there others places to correct the change than the docs and @deprecateing the old name?

[tkelman]

Worth adding a note about the renaming to NEWS.md perhaps?

[pkofod]

I've added a bullet. I chose favor in favour of favour, but both seem to be used throughout NEWS.md.

[pkofod]

I force pushed the change, so unfortunately your message is gone, but I've moved it to the correct section.

[pkofod]

Sorry, I actually remember having read that you should do that when adding something to NEWS.md. Thanks.

[andreasnoack]

@pkofod Could you rebase this?

[pkofod]

@andreasnoack I will fix it later, but yes.

I guess I just need to reorder and squash the commits, right?
Edit: i think i know what i should have done. Oh well, ill fix it.

[pkofod]

I hate and love git. Kind of messed the rebase up, but was able to go back, and it should be 👍 now

[pkofod]

What on earth did I do to make it build all the dependencies and fail? Did I err, or is it a travis thing?

[tkelman]

The Travis caching for dependencies was in a messed-up state, ref #15249, but it's fixed now - restarted.

[pkofod]

Thanks!

[andreasnoack]

@pkofod Thanks. It would be great if you could also add an entry to Compat.jl for issymmetric.

[KristofferC]

JuliaLang/Compat.jl#175 for a similar PR to compat.

[pkofod]

Sure, I'll do it later!