Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl.c's dependency on HEADERS is not mentioned in Makefile #13201

Closed
garrison opened this issue Sep 18, 2015 · 2 comments
Closed

repl.c's dependency on HEADERS is not mentioned in Makefile #13201

garrison opened this issue Sep 18, 2015 · 2 comments

Comments

@garrison
Copy link
Sponsor Member

src/Makefile defines a HEADERS variable with all the julia headers each object is likely to depend on, so that the object files in src will be recompiled if any julia header changes. However, ui/Makefile should do the same thing for ui/repl.c, but it does not -- the headers can change without repl.o being recompiled, and one can only compensate for this by running make clean explicitly. I discovered this after pulling from the release-0.4 branch where the VERSION was updated. After running make, ./julia --version returned the old version number, and the test suite failed. It wasn't until I ran make clean and re-ran the build that julia --version printed the correct string and the test suite passed.

@Keno
Copy link
Member

Keno commented Sep 18, 2015

dup of #12973 ;).

@Keno Keno closed this as completed Sep 18, 2015
@garrison
Copy link
Sponsor Member Author

thanks, searched for repl Makefile and didn't find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants