Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: JuliaLang/julia Loading
base: f46a78a26bdfe54d106328a49d99b5b47ad0e085
Choose a base ref
...
head repository: JuliaLang/julia Loading
compare: 7350c96286e2d28d19afa463e132058413ff1472
Choose a head ref
  • 3 commits
  • 9 files changed
  • 1 contributor

Commits on Aug 19, 2020

  1. Add argument typing and improve implementations 

    Since entire modules are marked `@nospecialize`, we need
to declare argument types anywhere we want good inference.
This also improves numerous implementations to ensure
inferrability.

For the completion methods, notice this changes typeof(ret[2]) from
UnitRange{Int64} to UnitRange{Int}. Internally, the methods are using
Int rather than Int64, so consistently using Int64 would require
more extensive changes.
    @timholy
    timholy committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    3495559 View commit details
    Browse the repository at this point in the history

  2. Add argtypes to keymap functions

    @timholy
    timholy committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    8db1ae6 View commit details
    Browse the repository at this point in the history

  3. Test inference in LineEdit

    @timholy
    timholy committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    7350c96 View commit details
    Browse the repository at this point in the history
Loading