Skip to content

Commit

Permalink
Merge pull request #30691 from JuliaLang/ksh/qrldivdiag
Browse files Browse the repository at this point in the history 
Get that last line in diagonal.jl covered
  • Loading branch information
@kshyatt
kshyatt committed Jan 12, 2019
2 parents e1ab87e + d59515f commit 88e1cb0
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions stdlib/LinearAlgebra/test/diagonal.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,11 @@ Random.seed!(1)
@test D/D2 ≈ Diagonal(D.diag./D2.diag)
@test D\D2 ≈ Diagonal(D2.diag./D.diag)

# QR \ Diagonal
A = rand(elty, n, n)
qrA = qr(A)
@test qrA \ D ≈ A \ D

# Performance specialisations for A*_mul_B!
vvv = similar(vv)
@test (r = Matrix(D) * vv ; mul!(vvv, D, vv) ≈ r ≈ vvv)
Expand Down

2 comments on commit 88e1cb0

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.