Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linspace tests fail on master #315

Closed
andreasnoack opened this issue Feb 1, 2017 · 2 comments
Closed

linspace tests fail on master #315

andreasnoack opened this issue Feb 1, 2017 · 2 comments
Labels

Comments

@andreasnoack
Copy link
Member

Probably because of JuliaLang/julia#18777. E.g.

julia> u=eps(zero(Float32));

julia> [Compat.linspace(-u,u,4);][3] == 0
false
@andreasnoack andreasnoack changed the title linspace test fail on master linspace tests fail on master Feb 1, 2017
@timholy
Copy link
Sponsor Member

timholy commented Feb 1, 2017

Yes, that test was one of the (few) casualties of the rewrite. It was advertised, see

I was also able to restore some of the tests that I had ditched in the original implementation of this PR. The only tests that I weakened were for cases where step underflows.

@andreasnoack
Copy link
Member Author

I guess we should just remove the tests here as well.

@tkelman tkelman closed this as completed Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants