Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

june-night: color blue is hard to read (used by Markdown-plugin for headers) #2

Closed
mkriele opened this issue Jun 20, 2014 · 6 comments

Comments

@mkriele
Copy link

mkriele commented Jun 20, 2014

I am using June as my standard theme. It works very well with Jewel but when using the Markdown-plugin, headers appear in standard blue and are hard to read. I believe that this is due to the lines

    .cm-s-june-night span.cm-header {
      color: blue; }

in june-night.css. As far as I can see, they are not used by Jewel. Would it be possible to change blue to a color that is easier to read on dark background?

@MikeInnes
Copy link
Contributor

Thanks for the report – I'll fix this as soon as I can. If you want to fix this temporarily you should be able to change the colour directly, perhaps to something like #F0EFD0.

@mkriele
Copy link
Author

mkriele commented Jun 20, 2014

Thanks for your fast answer and thanks for the hint. #F0EFD0 works well and is easy to read. The only draw back with this color is that it similar to the color used by bullet lists. I ended up using a light orange #FFCC99 which makes the headers stand out a little more.

@MikeInnes
Copy link
Contributor

Cool, I'll give the orange a go when I fix this.

@mkriele
Copy link
Author

mkriele commented Jun 20, 2014

I noticed that in the Markdown plugin links and names of links are also blue and not affected by the color for span.cm-header. As far as I can see this color is not set by june-night.css. Either a setting from june-night.css is overridden or june-night.css doe not address this type of mark-up.
I am not bothered by the link color and just wanted to alert you to it.

@MikeInnes
Copy link
Contributor

Ok, I went for the pretty lazy option of changing headers and links to your orange colour, it'll be in the next release. I haven't really made any effort to make June work well with Markdown yet, but it'll be on the list when I start doing more CSS work.

@mkriele
Copy link
Author

mkriele commented Jul 7, 2014

Thanks! The color scheme works great for my mark-down file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants