Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for contributing to KomaMRI using VSCode #382
base: master
Are you sure you want to change the base?
Documentation for contributing to KomaMRI using VSCode #382
Changes from 9 commits
6d1bf42
d406a2e
4bf706b
bd58ea7
0e08b7c
5cb222d
b855e76
9995fa5
750bab3
6f4cc82
a98d657
6606041
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing KomaMRI as a developer
Install dev version of Koma:
Now we will use the REPL to install Koma as a developer:
This command will clone KomaMRI.jl's repository (
dev
version) to~/.julia/dev/KomaMRI.jl/
.Open Koma dev in VSCode:
Now, open this folder in VScode using
File/Open Folder...
in the menu bar. The Julia extension should automatically detect theKomaMRI
environment. To check this, look at the status bar (bottom) and you should seeJulia env: KomaMRI.jl
. If this is not the case, click the option in the menu bar and select KomaMRI.jl.KomaMRI monorepo setup:
As KomaMRI.jl contains multiple packages in one GitHub repository, you need to specify that you want to use your local copies (instead of the ones available on the Julia registries) with:
Finally, use the
instantiate
command to install all the required packages (specified in theProject.toml
):This will also include all the specific package versions into the
Manifest.toml
. TheManifest.toml
should not be uploaded to the repo when making a commit or pull request. Thus, it is present in the.gitignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forking Koma
If you try to commit or generate a pull request at this point, you will get an
Access denied
error. This is because you need to create a fork before you can contribute to this repository directly (unless you are included as a collaborator!). To create a fork of KomaMRI.jl, go to KomaMRI.jl's GitHub and click the "Fork" button and follow the instructions:To use you fork in VSCode click "master" in the status bar:
and select your remote branch
username/KomaMRI.jl
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, the
KomaMRI
package has 4 subdirectories:KomaMRIBase
,KomaMRICore
,KomaMRIPlots
andKomaMRIFiles
. These subdirectories are julia packages by themselves, so they have their ownProject.toml
which is needed to resolve the environment ultimately defined byManifest.toml
. The directories are not separate git submodules.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commiting your first pull request
So far, so good. Let's make some changes.
Create a branch:
First, create a branch with a descriptive name, in this case
my-new-cool-feature
:Make some changes to the code:
CHANGE TO SIMPLER EXAMPLE. Modify README, or something.
Commit changes:
TODO. We encourage to
Publish a pull request:
TODO
Review process:
In Koma we require all pull requests to pass our automated tests ... TODO ... do not be afraid if you get an X in nightly because ...