Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mul! falls back to generic implementation #148

Closed
rveltz opened this issue Feb 19, 2019 · 2 comments
Closed

mul! falls back to generic implementation #148

rveltz opened this issue Feb 19, 2019 · 2 comments
Labels
cuda array Stuff about CuArray. enhancement New feature or request

Comments

@rveltz
Copy link

rveltz commented Feb 19, 2019

Describe the bug
Calling mul! falls back to generic implementation unlike calling rmul!

To Reproduce
The Minimal Working Example (MWE) for this bug:

using CuArrays, LinearAlgebra
CuArrays.allowscalar(false)
rhs = rand(1000000)
rhs_d = cu(rhs)
#this works:
rmul!(rhs_d,1.0)

#this fails:
mul!(rhs_d,rhs_d,1.0)

Environment details (please complete this section)
Details on Julia:

# please post the output of:
versioninfo()

julia> versioninfo()
Julia Version 1.0.3
Commit 099e826241* (2018-12-18 01:34 UTC)
Platform Info:
OS: Linux (x86_64-redhat-linux)
CPU: Intel(R) Xeon(R) CPU E5-2637 v4 @ 3.50GHz
WORD_SIZE: 64
LIBM: libopenlibm


@MikeInnes
Copy link
Contributor

I think mul! slightly predates CuArrays so there's probably just a dispatch case that's missed, should be easy to hook up.

@maleadt maleadt transferred this issue from JuliaGPU/CuArrays.jl May 27, 2020
@maleadt maleadt added cuda array Stuff about CuArray. enhancement New feature or request labels May 27, 2020
@maleadt
Copy link
Member

maleadt commented Apr 27, 2024

This works now.

@maleadt maleadt closed this as completed Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda array Stuff about CuArray. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants