Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\ does not work for least squares #104

Closed
kazimuth opened this issue Dec 12, 2019 · 5 comments
Closed

\ does not work for least squares #104

kazimuth opened this issue Dec 12, 2019 · 5 comments
Labels
bug Something isn't working cuda array Stuff about CuArray. good first issue Good for newcomers

Comments

@kazimuth
Copy link

Currently \ only works for square matrices. If I try to solve an overdetemined system (i.e. using least squares), it gives an error.

Example:

A = randn(Float32, 6, 5)
y = randn(Float32, 6)
A \ y # works
gpu(A) \ gpu(y) # gives DimensionMismatch("LU factored matrix A must be square!")

Ideally this should "just work" like it does for normal arrays.

@maleadt maleadt transferred this issue from JuliaGPU/CuArrays.jl May 27, 2020
@maleadt maleadt added bug Something isn't working cuda array Stuff about CuArray. labels May 27, 2020
@cpfiffer
Copy link

cpfiffer commented Feb 8, 2022

Any movement on this issue?

@maleadt
Copy link
Member

maleadt commented Feb 9, 2022

Nobody has fixed this, no.

@maleadt maleadt added the good first issue Good for newcomers label Feb 9, 2022
@cossio
Copy link
Contributor

cossio commented Nov 26, 2022

Running into this too. Any hints as to where in the source code should one look to attempt to fix this?

@amontoison
Copy link
Member

Running into this too. Any hints as to where in the source code should one look to attempt to fix this?

I think that the culprit is here.

@maleadt
Copy link
Member

maleadt commented Apr 27, 2024

This seems to work now.

@maleadt maleadt closed this as completed Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuda array Stuff about CuArray. good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants