Need to change Sort.foo imports

[dmbates]

Suddenly this morning I needed to remove lines of

import Sort.Perm

in src/pooleddataarray.jl and

import Sort.sort, Sort.sortby, Sort.By, 
       Sort.sort!, Sort.sortby!,
       Sort.Algorithm, Sort.Ordering, 
       Sort.lt, Sort.Perm, Sort.Forward

in src/dataframe.jl and then add

import Base.Sort.Algorithm, Base.Sort.Ordering
import Base.Sort.Perm, Base.Sort.Forward

in src/DataFrames.jl to get the DataFrames package to load.

I didn't see any changes in either the DataFrames package or Julia herself that should have caused this change. Am I doing something wrong with versions or should I commit these changes?

[tshort]

I think it's from this:

JuliaLang/julia#2375

I assume someone will clarify this later today.

[dmbates]

Shall I commit these changes?

[johnmyleswhite]

If they're needed to get the package to work at all, please go ahead and commit the changes. @kmsquire is the real expert on sorting and will have the most useful insight into this.

[ViralBShah]

I think that @StefanKarpinski needs to weigh in, since he is the last person to have overhauled the sort stuff. It is worth checking if the sorting documentation has kept up with the implementation.

[kmsquire]

As pointed out by @tshort, this is related to JuliaLang/julia#2375, and isn't related to sorting at all.

Basically the issue is that modules defined in Base used to shadow top level modules. Sort, in particular, is really Base.Sort, but @JeffBezanson felt that it wasn't good to shadow a potential Sort package, so the "fix" was to start requiring full qualification of subpackages.

For sorting to work properly for DataFrames, the rest of the imports (Base.Sort.sort, Base.Sort.sortby, etc.) will also need to be there. @dmbates, do you mind including these changes?

(Jeff, this has come up a few times, so it would probably be good to announce it on julia-dev, if you haven't already.)

[kmsquire]

"isn't related to sorting" -> "isn't _specifically_ related to sorting"

[dmbates]

Fixed via 5517155

[kmsquire]

Thanks!

[dmbates]

Fixed via b936f7119eb52322dfd142bc70df3d387b14119e