Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect [skip ci] #340

Open
IanButterworth opened this issue Feb 21, 2024 · 3 comments
Open

Respect [skip ci] #340

IanButterworth opened this issue Feb 21, 2024 · 3 comments

Comments

@IanButterworth
Copy link
Contributor

We should probably stick to the standard github approach.

https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs

Workflows that would otherwise be triggered using on: push or on: pull_request won't be triggered if you add any of the following strings to the commit message in a push, or the HEAD commit of a pull request:

  • [skip ci]
  • [ci skip]
  • [no ci]
    ...
@inkydragon
Copy link
Contributor

commit message in a push, or the HEAD commit of a pull request

And maybe: ... OR title of the pull request OR label of a pull request.

In both cases, when one removes the "skip ci" in the title or removes the label, new commits will trigger the CI normally.

@DilumAluthge
Copy link
Member

Buildkite is supposed to already come with [skip ci] support built in: https://buildkite.com/docs/pipelines/skipping#ignore-a-commit

If I recall correctly, Buildkite will not respect [skip ci] when a PR is first opened (that is, Buildkite will always run CI when a PR is first opened), but if you push subsequent commits to an existing PR, Buildkite will respect [skip ci] if present in those commit messages.

I'm not sure if that is a bug or the intended behavior.

@IanButterworth
Copy link
Contributor Author

Interesting. It might be nice if it could check the PR title too, which seems possible from your link

Also some granularity

  • [skip ci] skips all CI
  • [skip tests] builds but skips tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants