Expand signature of normalize from StaticVector to StaticArray (fixes #887)
#945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszbaran
approved these changes
Aug 1, 2021
|
Could you bump the patch version? I'll merge this. |
|
Sure, done! |
|
As an aside: #944 should be pretty harmless and might be nice to merge along with this if we're bumping the patch number anyway. |
|
OK, I'll merge both and then tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #887 in the simplest way possible.
Note that the existing
normalizeimplementation doesn't have many guard-rails (e.g., no over/underflow detection) andnormalize!has some rough edges (e.g., doesn't work for arrays withInteltype) - but I figured I'd just keep this to the scope of #887.