Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail deploying documents since switching to GitHub Actions #870

Closed
hyrodium opened this issue Jan 17, 2021 · 2 comments · Fixed by #872
Closed

Fail deploying documents since switching to GitHub Actions #870

hyrodium opened this issue Jan 17, 2021 · 2 comments · Fixed by #872

Comments

@hyrodium
Copy link
Collaborator

There are no deployed documents on gh-pages branch since the PR #752.
https://github.com/JuliaArrays/StaticArrays.jl/tree/gh-pages

I think, this is because Documenter.auto_detect_deploy_system() is failing to detect GitHub Actions, and the function is detecting Travis mistakenly.

Here's a screenshot from GitHub Actions.
image

It should be like this:
image

The functions auto_detect_deploy_system() is detecting the system from environment variables, so we should check them.
https://github.com/JuliaDocs/Documenter.jl/blob/master/src/deployconfig.jl#L825

@fredrikekre
Copy link
Member

Very old Documenter.jl version https://github.com/JuliaArrays/StaticArrays.jl/blob/master/docs/Project.toml#L5

@hyrodium
Copy link
Collaborator Author

Okay, I'll make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants