Bugfix: newsize not defined in error message #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at the history, this is pretty old code, and the special case `v <: StaticArray` seems unnecessary now — the compiler should have no trouble computing `length(v)` as a constant and eliminating the branch when `v` is a static array.
c42f
force-pushed
the
cjf/fix-undef-newsize
branch
from
096a7dd
to
2699c46
Compare
Merged
c42f
added a commit
that referenced
this pull request
Jan 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the history, this is pretty old code, and the special case
v <: StaticArrayseems unnecessary now — the compiler should have notrouble computing
length(v)as a constant and eliminating the branchwhen
vis a static array.Fixes #866