Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncallable method of _mul #813

Closed
mateuszbaran opened this issue Aug 11, 2020 · 1 comment · Fixed by #814
Closed

Uncallable method of _mul #813

mateuszbaran opened this issue Aug 11, 2020 · 1 comment · Fixed by #814
Labels

Comments

@mateuszbaran
Copy link
Collaborator

This method of _mul:

@generated function _mul(Sa::Size{sa}, Sb::Size{sb}, a::Union{SizedMatrix{T}, MMatrix{T}, MArray{T}}, b::Union{SizedMatrix{T}, MMatrix{T}, MArray{T}}) where {sa, sb, T <: BlasFloat}
can't be called because the first type argument of SizedMatrix etc. is not element type but a size. Should we just delete it? Apparently we are doing fine without using it.

@andyferris
Copy link
Member

Yes cleaning up that code should be fine (it hasn’t been looked at thoroughly for years).

@mateuszbaran mateuszbaran linked a pull request Aug 12, 2020 that will close this issue
@c42f c42f added the cleanup label Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants