Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scalar(1, 2) === Scalar((1, 2))? #809

Closed
tkf opened this issue Jul 10, 2020 · 1 comment · Fixed by #1016
Closed

Scalar(1, 2) === Scalar((1, 2))? #809

tkf opened this issue Jul 10, 2020 · 1 comment · Fixed by #1016
Labels
bug

Comments

@tkf
Copy link
Member

tkf commented Jul 10, 2020 •
edited
Loading

Currently,

julia> Scalar(1, 2) === Scalar((1, 2))
true

But I guess disallowing Scalar(1, 2) is sensible? It's a subset of #518 but I think just throwing a method error or augment error here is an easy fix.

ref #774
@c42f c42f added the bug label Sep 16, 2020
@c42f
Copy link
Member

c42f commented Sep 29, 2020

Yeah, definitely seems like a bug. Let's disallow it before releasing 1.0.

@N5N3 N5N3 mentioned this issue Mar 5, 2022
Merged
@N5N3 N5N3 mentioned this issue Mar 22, 2022
Merged
This was referenced Apr 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code clean and reuse for constructor. N5N3/StaticArrays.jl
2 participants
@tkf @c42f