-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag a new release? #142
Comments
Nice! I think master is in reasonable shape for a tag. Looks like it will be 0.5.0, with #127 a breaking change. Release notes roughly as follows - Bug fixes: Minor feature additions and fixes Breaking changes: It looks like bd3236a could do with a little more test coverage. @andyferris do you think we're in reasonable shape to tag? |
@andyferris what do you want to do with #134 vs just tagging right away (probably with #138 merged too though). If we go right ahead with #134, we haven't given any time for stabilization before releasing a big breaking change... which doesn't seem ideal. On the plus side, it means users can get the breakage of #127 and #134 over together, and they are rather related. |
My preference is to merge #134 first (or at least get feedback if it is desirable). Otherwise we'd need 0.5.0 and 0.6.0 and yeah, it's related to Keno's work. |
Ok I reviewed #134. It seems fairly harmless overall and worth getting merged to avoid saddling users with yet another breaking version. |
We need to get this done, I don't want to be blocking people - I'll tag and release tomorrow unless there's any objections. Updated release notes: Release 0.5.0 Breaking changes:
Feature additions and fixes:
Bug fixes:
|
Sounds great to me! |
I guess there are a couple of bug fixes remaining? |
There's still #125 but I'm happy to tag first and bugfix that one afterwards. |
Nice, thanks Andy, I'll review those asap. Definitely let's put further bug fixing into the next release... as long as there's not more than the previous release I'm happy ;-) |
Thanks again to both of you for your hard work making such a useful package! |
Being the swashbuckling Julian that I am, I decided to throw caution to the wind and implement JuliaDiff/ForwardDiff.jl#215 against StaticArrays master rather than latest tag (mainly because I wanted #127).
Would it be possible to tag a new release here, so that I can get Travis passing for JuliaDiff/ForwardDiff.jl#215?
Thanks!
The text was updated successfully, but these errors were encountered: