Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force specialization of dimension_mismatch_fail() on type parameter? #1244

Closed
trahflow opened this issue Feb 14, 2024 · 1 comment
Closed

Force specialization of dimension_mismatch_fail() on type parameter? #1244

trahflow opened this issue Feb 14, 2024 · 1 comment

Comments

@trahflow
Copy link
Contributor

Currently the function dimension_mismatch_fail(SA::Type, a::AbstractArray) does not specialize on the SA parameter, which makes code that uses StaticArrays inside GPU kernels incompatible (unless @inbounds is used in front of the constructor/convert statements).
See the discussion here: https://discourse.julialang.org/t/problems-with-linearalgebra-functions-within-kernelabstractions-and-cuda/97566/5

Would it be ok to force specialization on the SA parameter? I could provide a quick PR.
@trahflow trahflow mentioned this issue Feb 20, 2024
Merged
@mateuszbaran
Copy link
Collaborator

Resolved by #1245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trahflow @mateuszbaran